[17.0][FIX] account_payment_order: filter out non-draft moves when cancelling payments #1517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
payments Calling `action_draft()` on `draft` moves raises a UserError which blocks the "Cancel Payments" button from working properly.
MaxyMoos
force-pushed
the
17.0-account_payment_order-fix-cancel-payments-draft-move
branch
from
b922b4f to
84dec6b
Compare
pedrobaeza
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module
account_payment_order
Describe the bug
Clicking on the Cancel Payments button on a Payment Order can raise an Exception:
To Reproduce
Affected versions: 17.0
-> An error message appears, as calling
action_draft()ondraftmoves raises a UserError which blocks the "Cancel Payments" button from working properlyThe Cancel Payments button works properly once the Payment Order has reached the
uploadedstate, but not before, according to my tests.This fix just filters out
account.payment-linked moves by their state so they are only impacted by theaction_draftcall if they are not already indraftstate.